Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix data race in IndexNestedLoopHashJoin #55824

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Sep 3, 2024

What problem does this PR solve?

Issue Number: close #49692

Problem Summary:

  • IndexNestedLoopHashJoin.panicErr is not thread-safe

What changed and how does it work?

  • make IndexNestedLoopHashJoin.panicErr can not be read until it has been initialized.
  • add failpoint TestIssue49692 to make sure the context done branch can be executed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Manual test:

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/invalid-title do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 3, 2024
Copy link

tiprow bot commented Sep 3, 2024

Hi @solotzg. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 56.4173%. Comparing base (eb19c10) to head (f36bc7a).
Report is 27 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55824         +/-   ##
=================================================
- Coverage   72.8613%   56.4173%   -16.4441%     
=================================================
  Files          1595       1728        +133     
  Lines        449065     624992     +175927     
=================================================
+ Hits         327195     352604      +25409     
- Misses       101574     248574     +147000     
- Partials      20296      23814       +3518     
Flag Coverage Δ
integration 37.5592% <5.2631%> (?)
unit 71.9436% <63.1578%> (+0.0059%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (+0.0266%) ⬆️
parser ∅ <ø> (∅)
br 52.6590% <ø> (+7.2834%) ⬆️

2
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg solotzg changed the title WIP executor: fix data race in IndexNestedLoopHashJoin Sep 4, 2024
3
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 4, 2024
@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2024

/test unit-test

Copy link

tiprow bot commented Sep 4, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

4
Signed-off-by: TONG, Zhigao <tongzhigao@pingcap.com>
@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2024

/cc @XuHuaiyu @wshwsh12

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
Copy link

ti-chi-bot bot commented Sep 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wshwsh12, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 4, 2024
Copy link

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-04 08:04:34.130023504 +0000 UTC m=+431598.648076443: ☑️ agreed by XuHuaiyu.
  • 2024-09-04 08:24:27.795540411 +0000 UTC m=+432792.313593334: ☑️ agreed by wshwsh12.

Copy link

ti-chi-bot bot commented Sep 4, 2024

@solotzg: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test f36bc7a link unknown /test unit-test
pull-integration-ddl-test f36bc7a link unknown /test pull-integration-ddl-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2024

/retest-required

Copy link

tiprow bot commented Sep 4, 2024

@solotzg: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 8cdd449 into pingcap:master Sep 4, 2024
21 of 23 checks passed
@solotzg solotzg deleted the fix-49692 branch September 4, 2024 12:02
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Sep 6, 2024
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #55907.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #55908.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #55909.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #55910.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #55911.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Sep 6, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot bot pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DATA RACE in the executor.(*IndexNestedLoopHashJoin)
4 participants